Use __atomic_store_n() instead of __sync_test_and_set() for lsapi #9976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did a full replacement of __sync_xxxx() with __atomic_xxxx(), please check 4bdfce6 |
|
Thank you! it fixes even 8.0 4bdfce6 The clean-up and configuration of atomics could use follow-up issue instead of #7914 (comment) I mean it needs separate issue to unify usage of atomics |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #7997 (comment) (it builds fine on RV64 arch)
Related to #7914 but probably better to unify usage #7914 (comment)